Use mocha, istanbul, and coveralls #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warbrett
reviewed
Aug 30, 2017
test/parse.js
Outdated
| t.end(); | ||
| describe('parse', function(){ | ||
|
|
||
| it('using connection string in client constructor', function(done){ |
There was a problem hiding this comment.
None of these tests are async so you can remove the done arg as well as the done call at the end.
warbrett
requested changes
Aug 30, 2017
warbrett
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to get better at maintaining our stuff :)
would like to match this to the rest of our patterns