feat(zip): better string encoding handling #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
piksel
force-pushed
the
zipstrings-instance
branch
from
99c232a to
3b126e9
Compare
This comment has been minimized.
This comment has been minimized.
Numpsy
reviewed
Mar 13, 2021
Numpsy
reviewed
Mar 13, 2021
This was
linked to
issues
Mar 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 73.82% 73.79% -0.03%
==========================================
Files 69 68 -1
Lines 8291 8332 +41
==========================================
+ Hits 6121 6149 +28
- Misses 2170 2183 +13
Continue to review full report at Codecov.
|
piksel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the global static
ZipStringssingleton with instances ofStringCodec, which will:ZipCryptoand zip archive comments (the one in the Central Directory, not the individual entry comments).Since the only way to customize Encoding handling in zipfiles until now has been to modify the static
ZipStringssingleton, and we don't want to break backwards compatibility, it will now use separate instances for allZipFile/Zip*Streaminstances unlessZipStringshas been modified.It's still not a great API, but the properties are marked as deprecated and should be removable in a later release.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.