Fix handling of paths on Linux and Mac (issue #54) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation on unix systems
Linux and Mac use a forward slash instead of a backslash to separate directories. This change makes use of the Path.DirectorySeparatorChar instead of hardcoding backslash. This allows to use the same code on all platforms. This change also adjusts the WindowsNameTransform tests so that they also work cross-platform.
|
What's the status of this PR? Is it likely to be accepted soon? |
|
Bump. Any update on this getting merged? |
jfreilly
added a commit
that referenced
this pull request
Jul 14, 2015
Fix handling of paths on Linux and Mac (issue #54)
|
WindowsNameTransform was never intended to be generic a clue being the name including Windows but this works fine. It would be good to rename the class but this itself causes issues. |
Closed
|
My Contribution is licensed under the MIT License. |
This was referenced Apr 14, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux and Mac use a forward slash instead of a backslash to separate
directories. This change makes use of the Path.DirectorySeparatorChar
instead of hardcoding backslash. This allows to use the same code on
all platforms.
This change also adjusts the WindowsNameTransform tests so that they
also work cross-platform.
Incorporated in this PR is #52.