Skip to content

prepare for v1.4.0 #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2022
Merged

prepare for v1.4.0 #755

merged 4 commits into from
Sep 18, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented May 24, 2022

this branch contains changes needed for the upcoming release, mainly related to .NET 6

The new target frameworks will be:

  • .NET Standard 2.0 (for .NET framework 4.6.2+)
  • .NET Standard 2.1 (general support for all but .NET framework)
  • .NET 6.0 (new LTS)

the main issue stems from the fact that the AES auth code reading is handled inside a class inheriting from CryptoStream. For that to work correctly, the reads cannot be bypassed by more efficient code (which is what is happening in the .NET 6 version of CryptoStream).
In fact, the entire ZIPAESStream should probably just be removed altogether, since it seems to just be a work around for having the auth code appended to the input stream. this can be handled much easier in the TransformLastBlock method of ZipAESTransform.

that approach is now used by async reads on .NET 6.0, but others still use the legacy code. this was done to do as little as possible to allow SharpZipLib to work with .NET 6, but it really ought to be replaced for all usages.

@piksel piksel force-pushed the release/v1.4.0 branch 2 times, most recently from 0af9f15 to 7f28639 Compare May 24, 2022 14:54
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #755 (e76dc02) into master (519ed73) will increase coverage by 0.08%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   74.60%   74.68%   +0.08%     
==========================================
  Files          72       72              
  Lines        8457     8447      -10     
==========================================
  Hits         6309     6309              
+ Misses       2148     2138      -10     
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.28% <ø> (ø)
...ib/Zip/Compression/Streams/DeflaterOutputStream.cs 82.47% <ø> (+7.70%) ⬆️
...harpCode.SharpZipLib/Encryption/ZipAESTransform.cs 88.46% <82.35%> (-0.63%) ⬇️
src/ICSharpCode.SharpZipLib/Core/EmptyRefs.cs 100.00% <0.00%> (ø)
.../ICSharpCode.SharpZipLib/BZip2/BZip2InputStream.cs 74.70% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonyliving
Copy link

Can I get it from nuget?

@piksel
Copy link
Member Author

piksel commented Jun 1, 2022

@tonyliving not until it has been released, no. If you want to try it out you can download the build artifact for this PR:
https://github.com/icsharpcode/SharpZipLib/suites/6639150865/artifacts/250580285

@carlreid
Copy link

carlreid commented Jul 6, 2022

@piksel Me again 🙈 Is there something blocking this from being released?

@piksel
Copy link
Member Author

piksel commented Jul 6, 2022

No, It's mainly because of me being busy with work. Sorry.

@carlreid
Copy link

carlreid commented Jul 6, 2022

No worries, take it easy 😊

@piksel piksel added this to the v1.4 milestone Aug 16, 2022
@carlreid
Copy link

It seems the artifact from the previous build has expired, is it possible you could re-trigger the build / release this version?

Was just about to host the pre-release package so we could make use of the fix #750

@piksel
Copy link
Member Author

piksel commented Sep 15, 2022

@carlreid I fixed the conflict and there should be a new artifact to download. Also, I fixed the last PR that was blocking release, so it should be ready by the weekend.

@carlreid
Copy link

Wonderful! Thank you 😊

In which case, I'll wait until next week to see if you managed to make it through with a release before trying to host the artifact.

@piksel piksel changed the title Release v1.4.0 prepare for v1.4.0 Sep 18, 2022
@piksel piksel merged commit cea8b0d into master Sep 18, 2022
@piksel piksel deleted the release/v1.4.0 branch September 18, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants