-
Notifications
You must be signed in to change notification settings - Fork 995
prepare for v1.4.0 #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for v1.4.0 #755
Conversation
0af9f15
to
7f28639
Compare
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 74.60% 74.68% +0.08%
==========================================
Files 72 72
Lines 8457 8447 -10
==========================================
Hits 6309 6309
+ Misses 2148 2138 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Can I get it from nuget? |
@tonyliving not until it has been released, no. If you want to try it out you can download the build artifact for this PR: |
@piksel Me again 🙈 Is there something blocking this from being released? |
No, It's mainly because of me being busy with work. Sorry. |
No worries, take it easy 😊 |
It seems the artifact from the previous build has expired, is it possible you could re-trigger the build / release this version? Was just about to host the pre-release package so we could make use of the fix #750 |
f129cd3
to
e76dc02
Compare
@carlreid I fixed the conflict and there should be a new artifact to download. Also, I fixed the last PR that was blocking release, so it should be ready by the weekend. |
Wonderful! Thank you 😊 In which case, I'll wait until next week to see if you managed to make it through with a release before trying to host the artifact. |
this branch contains changes needed for the upcoming release, mainly related to .NET 6
The new target frameworks will be:
the main issue stems from the fact that the AES auth code reading is handled inside a class inheriting from
CryptoStream
. For that to work correctly, the reads cannot be bypassed by more efficient code (which is what is happening in the .NET 6 version ofCryptoStream
).In fact, the entire
ZIPAESStream
should probably just be removed altogether, since it seems to just be a work around for having the auth code appended to the input stream. this can be handled much easier in the TransformLastBlock method of ZipAESTransform.that approach is now used by async reads on .NET 6.0, but others still use the legacy code. this was done to do as little as possible to allow SharpZipLib to work with .NET 6, but it really ought to be replaced for all usages.