Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar long names #86

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Fix tar long names #86

merged 2 commits into from
Apr 15, 2016

Conversation

creker
Copy link
Contributor

@creker creker commented Sep 16, 2015

Was using the library to generate debian packages which use Tar inside. Files with names longer than 100 symbols were preventing the package from installing - dpkg couldn't copy the files with the long names. Looking at the specification and Tars generated on Linux with default tools I found several bugs:

  • Ustar format supports names up to 100 symbols. That is, if a name is exactly 100 symbols you don't need to write terminating symbol. SharpZipLib truncates names to 99 symbols
  • "@LongLink" should have default 644 mode. SharpZipLib doesn't specify it
  • "@LongLink" should have user ID, user name, group ID and group name from the entry it belongs to. SharpZipLib doesn't specify them

@McNeight McNeight added the bug label Apr 14, 2016
@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight McNeight mentioned this pull request Apr 14, 2016
@creker
Copy link
Contributor Author

creker commented Apr 14, 2016

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the #develop open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@McNeight McNeight merged commit 30c3434 into icsharpcode:master Apr 15, 2016
@McNeight McNeight added tar Related to TAR file format and removed tar Related to TAR file format labels Apr 15, 2016
@McNeight
Copy link
Contributor

McNeight commented May 9, 2016

Artem,

Спасибо за отвечать на запросы, и поблагодарить Вас за Ваш вклад.

-Neil

@icsharpcode icsharpcode locked and limited conversation to collaborators May 9, 2016
@McNeight McNeight modified the milestone: 1.0 May 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug tar Related to TAR file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants