Skip to content

Add the option to run lint and unit test locally. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ignacio-chiazzo opened this issue Oct 8, 2022 · 3 comments
Closed

Add the option to run lint and unit test locally. #65

ignacio-chiazzo opened this issue Oct 8, 2022 · 3 comments

Comments

@ignacio-chiazzo
Copy link
Owner

ignacio-chiazzo commented Oct 8, 2022

The current repository uses a Github Action for running linters Github workflows

Add the option to run the linter locally by running commands. Optionally we can combine unit tests and lint and run them all in one command. There are also a few tests failing that should be updated.

@hot9cups
Copy link
Collaborator

hot9cups commented Oct 9, 2022

As a first step, all the existing lint errors have been fixed, and the failing tests have been updated.
These changes can be found in the following PR - #67

@hot9cups
Copy link
Collaborator

I see that

  1. EsLint and Tests fix #67 fixed the failing tests and linting errors.
  2. Enhancing Tests.js logic #76 has the unit tests enhanced, node Tests.js enables running unit tests locally.
  3. Add linter to the README #70 enables running linter and automatic fixing locally via eslint --fix.

Once #76 is merged, I think we should be good to close this issue?

@ignacio-chiazzo
Copy link
Owner Author

Thanks for the amazing work on this @hot9cups!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants