Skip to content

Add linter to the README #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add linter to the README #70

merged 2 commits into from
Oct 18, 2022
+3 −2

Conversation

ignacio-chiazzo
Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo commented Oct 17, 2022 •
edited
Loading

@ignacio-chiazzo
Add linter to the README

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ea4c4ae
hot9cups
hot9cups reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@hot9cups hot9cups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add instructions on how to fix the linting errors, there is a command eslint fix to do that, as just running the tests locally might not be enough.

@ignacio-chiazzo
Update README.md

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
07fe682
@ignacio-chiazzo ignacio-chiazzo merged commit c9f1a87 into master Oct 18, 2022
@hot9cups hot9cups mentioned this pull request Oct 23, 2022
Closed
@ignacio-chiazzo ignacio-chiazzo deleted the ignacio-chiazzo-patch-1 branch October 28, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hot9cups hot9cups

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignacio-chiazzo @hot9cups