-
Notifications
You must be signed in to change notification settings - Fork 42
Add initial code owners #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
- Coverage 77.6% 76.7% -1.0%
=======================================
Files 211 211
Lines 16079 16079
=======================================
- Hits 12481 12333 -148
- Misses 3598 3746 +148 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for setting this up! I assume we're not setting an owner for message-ix-models/report
because no one is clearly responsible for this part? If we find someone to work on replicating all legacy reporting features here, we can add them :)
As for one of your questions, it is recommended as the most secure practice to define the repository owners as the owners of .github/
or at least .github/CODEOWNERS
.
.github/CODEOWNERS
Outdated
# message_ix_models/project/advance | ||
# message_ix_models/project/circeular | ||
# message_ix_models/project/edits | ||
# message_ix_models/project/engage | ||
# message_ix_models/project/gea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these should eventually also include the relevant doc pages, i.e. doc/project/advance
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. There is a distinction between completed projects and current/future projects. I have not yet added the docs but will put some indicative language about how those should be handled.
Thanks for spotting that. It seems we don't have an explictly-defined owner for the repo, only:
I guess for now I will add the two of us.
That's one of many areas where I wrote some initial code but it would be good to have joint contributions (possibly many people) to (a) expanding and (b) maintaining it. I'm not sure yet how that maps to the idea of "owner" and review duties, so I've left it out for now. Someday we could aim for having an owner for most files, but use non-ownership to designate code as unmaintained, as an indication that people should not rely on it or that we intend to migrate to better solutions and deprecate it. |
7ff17b1
to
ff67aa1
Compare
This PR adds an initial set of code owners, as discussed at today's MESSAGE team meeting.
Some notes:
.github/CODEOWNERS @khaeru @glatterf42
or similar to ensure people are requested to review changes to the owners file itself. I would need to look around for other uses of this feature to see if that's common.How to review
I've requested review from everyone who'll be affected by this change.
PR checklist
Add or expand tests;coverage checks both ✅