Skip to content

Handle IEA extended world energy balances #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 24, 2024
Merged

Handle IEA extended world energy balances #75

merged 38 commits into from
Jan 24, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 12, 2022

Closes #25.

The code supports the same uses as the more recent https://github.com/SiddharthJoshi-Git/IEA_activity_calib_SSP.

How to review

  • Check out the branch.
  • Attempt to follow the docs instructions, using the data with a full-scale database (not included).

PR checklist

  • Complete the code
    • Add fuzzed data for testing.
  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added the enh New features or functionality label May 12, 2022
@khaeru khaeru self-assigned this May 12, 2022
@khaeru khaeru changed the title Handle IEA extended world energy balances #25 Handle IEA extended world energy balances May 12, 2022
@khaeru
Copy link
Member Author

khaeru commented Nov 24, 2022

Just a note that this should probably be using PyArrow, e.g. https://francoismichonneau.net/2022/10/import-big-csv/

@khaeru khaeru force-pushed the issue/25 branch 2 times, most recently from 7537165 to beb38e2 Compare January 19, 2024 11:51
khaeru added a commit that referenced this pull request Jan 20, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fdfb4c9) 74.9% compared to head (1988bc1) 74.5%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #75     +/-   ##
=======================================
- Coverage   74.9%   74.5%   -0.4%     
=======================================
  Files         91      93      +2     
  Lines       6084    6204    +120     
=======================================
+ Hits        4558    4625     +67     
- Misses      1526    1579     +53     
Files Coverage Δ
message_ix_models/project/ssp/structure.py 100.0% <100.0%> (ø)
message_ix_models/testing/cli.py 88.8% <100.0%> (+3.1%) ⬆️
message_ix_models/tests/project/test_ssp.py 100.0% <100.0%> (ø)
message_ix_models/tests/tools/iea/test_web.py 100.0% <100.0%> (ø)
message_ix_models/tools/iea/web.py 100.0% <100.0%> (ø)
message_ix_models/util/sdmx.py 97.0% <90.0%> (-0.9%) ⬇️

... and 2 files with indirect coverage changes

@khaeru
Copy link
Member Author

khaeru commented Jan 24, 2024

The codecov/project check failure here appears to be erroneous. Codecov shows missing lines in .model.snapshot, but the job itself shows 100% coverage in the same file.

@khaeru khaeru merged commit 99244af into main Jan 24, 2024
@khaeru khaeru deleted the issue/25 branch January 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve and process IEA extended world energy balances
1 participant