Skip to content

Add criticism to Service Locator #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iluwatar opened this issue Jun 26, 2016 · 1 comment
Closed

Add criticism to Service Locator #436

iluwatar opened this issue Jun 26, 2016 · 1 comment
Labels
info: good first issue type: enhancement
Milestone
1.14.0

Comments

@iluwatar
Copy link
Owner

More information could be added to Consequences section of the Service Locator pattern.

http://criticalsoftwareblog.com/index.php/2015/10/25/object-composability-another-reason-why-the-service-locator-is-an-anti-pattern/

See the pattern template here: https://github.com/iluwatar/java-design-patterns/wiki/02.-Pattern-template
@dmitraver dmitraver mentioned this issue Oct 3, 2016
Closed
@iluwatar
Copy link
Owner Author

iluwatar commented Oct 3, 2016

Assigned to @dmitraver

dmitraver added a commit to dmitraver/java-design-patterns that referenced this issue Oct 3, 2016
@dmitraver
Closes iluwatar#436. Adds criticism to service locator pattern.
9512f3e
@dmitraver dmitraver mentioned this issue Oct 4, 2016
Merged
@iluwatar iluwatar added this to the 1.14.0 milestone Oct 18, 2016
dbryla pushed a commit to dbryla/java-design-patterns that referenced this issue Nov 4, 2016
Merge branch 'master' of https://github.com/iluwatar/java-design-patt…
0a42771 
…erns

* 'master' of https://github.com/iluwatar/java-design-patterns: (27 commits)
  Remove use of coveralls-maven-plugin (sonarqube.com covers this)
  Add SonarQube.com badge
  Fix environment variable
  Add Travis instructions for SonarQube.com analysis
  Adds more criticism to Singleton pattern.
  Event Based Asynchronous pattern: Add missing license header and puml diagram
  Changed config to non-interactive
  Moved config into a separate dir
  Unused import removed.
  End process logic clause has been corrected.
  Caching pattern: Documentation and diagram
  Fixes iluwatar#437. Adds criticism to Singleton pattern.
  Alter JUnit tests to run in lesser time.
  Updated version snapshot to 1.14.0
  Changes based on review feedback.
  Closes iluwatar#436. Adds criticism to service locator pattern.
  Caching pattern: Implementation of Cache-Aside pattern
  Caching pattern: Style fix for null check
  Caching pattern: Refactor LRU cache to avoid NPE and unnecessary cache lookup
  Caching pattern: Refactor shutdown hook to use method reference
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info: good first issue type: enhancement
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
1 participant
@iluwatar