Skip to content

Add currying pattern #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

januslinhc
Copy link

@januslinhc januslinhc commented Oct 14, 2021

#1842
Pull request description

  • Add currying samples with using basic Function interface and functional interfaces approaches
  • Add README doc for currying

@januslinhc januslinhc changed the title Add currying pattern #1842 Add currying pattern Oct 14, 2021
@januslinhc januslinhc marked this pull request as draft October 14, 2021 17:08
@januslinhc januslinhc marked this pull request as ready for review October 14, 2021 17:09
@ohbus ohbus self-assigned this Oct 17, 2021
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the failing build and try to synchronise this PR for triggering the CircleCI build.

@ohbus ohbus linked an issue Oct 17, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

50.8% 50.8% Coverage
0.0% 0.0% Duplication

@januslinhc
Copy link
Author

hi @iluwatar @ohbus , I have fixed the issues, please check! Thanks!

@januslinhc januslinhc requested review from iluwatar and ohbus October 26, 2021 05:57
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the review comments, please check why the build and SonarQube analysis are failing.

Comment on lines +2 to +5
layout: pattern title: Currying folder: currying permalink: /patterns/currying/ categories: Functional language: en
tags:

- Decoupling
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontmatter looks somehow messed up. Please check it.

@@ -27,6 +27,553 @@
ZK framework is licensed under LGPL and the license can be found at lgpl-3.0.txt

-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what is going on with these changes (such a large diff). Usually adding a new pattern requires adding only one line to this file.

@iluwatar iluwatar added the status: stale issues and pull requests that have not had recent interaction label Sep 21, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Sep 21, 2022
@iluwatar iluwatar closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currying
3 participants