Skip to content

Adding Choreography Pattern: #1328 #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

patbeagan1
Copy link

@patbeagan1 patbeagan1 commented Nov 3, 2021

  • Adds an example of the choreography pattern
  • Describes the pattern and its use cases
  • Approximates microservices with multiple threads

Preview the Readme here: https://github.com/iluwatar/java-design-patterns/blob/ddcec64d9b3bc827ae30f74c5a215a7bfd6bb60e/choreography/README.md

@patbeagan1
Copy link
Author

This is the first java code that I've written in a while, so I'm open to feedback!

I noticed the request for the commits to include issue numbers a bit late, hope that's still ok

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ohbus ohbus self-assigned this Nov 4, 2021
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution @patbeagan1

Please include the pattern inside the parent pom to being static code evaluation.

Fix all the static code errors and once the quality gate is passed you can request a review from us again!

Good Luck!

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Oct 30, 2022
@iluwatar
Copy link
Owner

iluwatar commented Nov 9, 2022

Closed due to inactivity

@iluwatar iluwatar closed this Nov 9, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants