add identity field pattern #1978
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed! |
|
hi, I have removed the code smells. As for the coverage, I can have full coverage locally. Not sure about how Sonar checks this. |
| @@ -0,0 +1,64 @@ | |||
| --- | |||
| layout: pattern | |||
| title: Identity-Field | |||
There was a problem hiding this comment.
| title: Identity-Field | |
| title: Identity Field |
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.22</version> |
There was a problem hiding this comment.
Please use the version from the parent pom.xml
| <plugin> | ||
| <artifactId>maven-assembly-plugin</artifactId> | ||
| <configuration> | ||
| <archive> | ||
| <manifest> | ||
| <mainClass>com.test.MainClassName</mainClass> | ||
| </manifest> | ||
| </archive> | ||
| <descriptorRefs> | ||
| <descriptorRef>jar-with-dependencies</descriptorRef> | ||
| </descriptorRefs> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <id>make-assembly</id> | ||
| <phase>package</phase> <!-- packaging phase --> | ||
| <goals> | ||
| <goal>single</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
The configuration seems overly verbose. Can you check how maven-assembly-plugin has been configured in the other patterns?
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>8</source> | ||
| <target>8</target> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
This should be left out. Use the Java version that's coming from the parent pom.xml (11)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status: stale
|
Closed due to inactivity |
stale
bot
removed
status: stale
In this pull request,
Pull request description