Skip to content

Update license plugin #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2022
Merged

Update license plugin #2020

merged 3 commits into from
Sep 14, 2022

Conversation

iluwatar
Copy link
Owner

@iluwatar iluwatar commented Sep 8, 2022 •
edited
Loading

  • Updates license-maven-plugin to the latest stable version
  • The configuration format has slightly changed, so the configuration is updated as well
  • The source code license headers were removed and the new ones added
  • Suppress unneeded Checkstyle rules

@iluwatar iluwatar requested a review from ohbus September 8, 2022 14:31
ohbus
ohbus reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing due to some error, I'm not able to check as the logs are huge.

Can you please check?

@ohbus ohbus self-assigned this Sep 8, 2022
@iluwatar
Copy link
Owner Author

iluwatar commented Sep 9, 2022

Pushed the fix. Hopefully the checks go through now.

@iluwatar iluwatar requested a review from ohbus September 9, 2022 19:17
ohbus
ohbus approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohbus ohbus merged commit 932836f into master Sep 14, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Sep 16, 2022
@iluwatar iluwatar deleted the upgrade-license-plugin branch December 30, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohbus ohbus ohbus approved these changes

Assignees

@ohbus ohbus

Labels
status: under review
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iluwatar @ohbus