-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
#1842 Add Currying Design Pattern #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… running site and deploy
iluwatar#1842 Add Currying Design Pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build and Sonar analysis are failing. Please fix these before submitting for review.
Hey @iluwatar, apologies for that. I plan on continuing work on this issue in about 2 weeks time. Sorry for the delay. |
Fixing Build Issues With Currying
Removing Code Smells
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a couple of minor changes. Otherwise, this looks very good!
Hey @iluwatar, I made the changes that you requested; however, the build fails when executing the Maven goal for the service-layer design pattern. Do you have any idea what might be causing this issue? |
Fixing code smell
Perhaps try to rebase your branch on top of |
Kudos, SonarCloud Quality Gate passed! |
Hey @iluwatar, made the changes that you asked for and the tests are now passing. |
Excellent, thank you for contributing the new design pattern! 🎉😄💪 @all-contributors please add @hkattt for code |
@all-contributors please add @hkattt for code |
I've put up a pull request to add @you! 🎉 I've put up a pull request to add @hkattt! 🎉 |
This PR resolves #1842.
I adapted the currying example suggested in the #1842 thread. My programmatic example focuses on using a curried builder function to create Book objects.