Skip to content

#1842 Add Currying Design Pattern #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Dec 4, 2022
Merged

#1842 Add Currying Design Pattern #2271

merged 41 commits into from
Dec 4, 2022

Conversation

hkattt
Copy link
Contributor

@hkattt hkattt commented Oct 29, 2022

This PR resolves #1842.

I adapted the currying example suggested in the #1842 thread. My programmatic example focuses on using a curried builder function to create Book objects.

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build and Sonar analysis are failing. Please fix these before submitting for review.

@hkattt
Copy link
Contributor Author

hkattt commented Nov 7, 2022

Hey @iluwatar, apologies for that. I plan on continuing work on this issue in about 2 weeks time. Sorry for the delay.

@hkattt hkattt requested a review from iluwatar November 15, 2022 23:41
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a couple of minor changes. Otherwise, this looks very good!

@hkattt
Copy link
Contributor Author

hkattt commented Nov 28, 2022

Hey @iluwatar, I made the changes that you requested; however, the build fails when executing the Maven goal for the service-layer design pattern. Do you have any idea what might be causing this issue?

@iluwatar
Copy link
Owner

iluwatar commented Dec 3, 2022

Perhaps try to rebase your branch on top of master to get rid of the build errors?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.1% 84.1% Coverage
0.0% 0.0% Duplication

@hkattt
Copy link
Contributor Author

hkattt commented Dec 4, 2022

Hey @iluwatar, made the changes that you asked for and the tests are now passing.

@hkattt hkattt requested a review from iluwatar December 4, 2022 03:28
@iluwatar iluwatar merged commit 7be2828 into iluwatar:master Dec 4, 2022
@iluwatar
Copy link
Owner

iluwatar commented Dec 4, 2022

Excellent, thank you for contributing the new design pattern! 🎉😄💪

@all-contributors please add @hkattt for code

@iluwatar
Copy link
Owner

iluwatar commented Dec 4, 2022

@all-contributors please add @hkattt for code

@allcontributors
Copy link
Contributor

@iluwatar

@hkattt already contributed before to code

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @you! 🎉

I've put up a pull request to add @hkattt! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currying
3 participants