Skip to content

removed weird link from mvvm #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

removed weird link from mvvm #2618

merged 1 commit into from
Oct 15, 2023

Conversation

inishantjain
Copy link
Contributor

@inishantjain inishantjain mentioned this pull request Oct 6, 2023
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

GiulioBernardi
GiulioBernardi reviewed Oct 6, 2023
View reviewed changes
Copy link

@GiulioBernardi GiulioBernardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't own the project so this is just a sugestion.
Once should there be a link to visitors to learn about MVVM, I don't think that delete the link is good.

Maybe it should just put a link that really takes you to a article about MVVM or something like it.

If agreed, I suggest to send to wikipedia page or microsoft page that talks about MVVM

ohbus
ohbus approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluwatar iluwatar merged commit f9c5e7e into iluwatar:master Oct 15, 2023
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @inishantjain for docs

@allcontributors allcontributors bot mentioned this pull request Oct 15, 2023
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @inishantjain! 🎉

sugan0tech pushed a commit to sugan0tech/java-design-patterns that referenced this pull request Nov 12, 2023
@inishantjain @sugan0tech
docs: removed weird link from mvvm (iluwatar#2618)
c3f112b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioBernardi GiulioBernardi GiulioBernardi left review comments

@iluwatar iluwatar iluwatar approved these changes

@ohbus ohbus ohbus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inishantjain @iluwatar @ohbus @GiulioBernardi