-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding backpressure design pattern #3233 #3249
Conversation
PR SummaryThis PR implements the backpressure design pattern in Java using Reactor. It includes a Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (3)
- 7c3ba8a: Merge branch 'iluwatar:master' into master
- 1fa515f: Adding backpressure pattern Implement Backpressure pattern #3233
- b8f51f0: Initial commit backpressure
temp
Files Processed (11)
- backpressure/README.md (1 hunk)
- backpressure/etc/backpressure.png (0 hunks)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- b85de31: Fix test case Implement Backpressure pattern #3233
Files Processed (10)
- backpressure/README.md (1 hunk)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 4552f83: Fix formatting Implement Backpressure pattern #3233
Files Processed (5)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java [36-42]
performance: "Inefficient delay simulation in
processItem
method."
Check out the Sonar issue |
@Slf4j | ||
public class Subscriber extends BaseSubscriber<Integer> { | ||
|
||
private static final Logger logger = LoggerFactory.getLogger(Subscriber.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to declare logger like this. With the Lombok annotation you automatically have LOGGER available.
backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 58af7b3: Changes after review Implement Backpressure pattern #3233
Files Processed (8)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 36131dd: Fix sonar error in leaderfollowers module Implement Backpressure pattern #3233
Files Processed (1)
- leader-followers/src/main/java/com/iluwatar/leaderfollowers/App.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
leader-followers/src/main/java/com/iluwatar/leaderfollowers/App.java [70-76]
best practice: "Resource Management Improvement"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 817cfbc: Merge branch 'master' into master
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @sanurah for code |
Pull Request Template
What does this PR do?
This PR is adding the backpressure design pattern
Relates to #3233