Module pattern #62 #512
Module pattern #62 #512
Conversation
FirstCut++
SecondCut++
checkstyle errors removed
| @@ -0,0 +1,95 @@ | |||
| /** | |||
| * The MIT License Copyright (c) 2016 Amit Dixit | |||
There was a problem hiding this comment.
Please retain the license header consistent e.g. The MIT License Copyright (c) 2014 Ilkka Seppälä
| public final class App { | ||
|
|
||
| public static FileLoggerModule fileLoggerModule = null; | ||
| public static ConsoleLoggerModule consoleLoggerModule = null; |
There was a problem hiding this comment.
These are initialized to null automatically. Check for similar occurrences elsewhere.
|
|
||
| /* Prepare modules */ | ||
| fileLoggerModule.prepare(); | ||
| consoleLoggerModule.prepare(); |
There was a problem hiding this comment.
It would be possible to create the object and prepare it on one line
There was a problem hiding this comment.
Method prepare() is independent to demonstrate modular aspect of pattern. Please clarify.
| * the creation and organization of other elements, and groups them as the structural pattern does. | ||
| * An object that applies this pattern can provide the equivalent of a namespace, providing the | ||
| * initialization and finalization process of a static class or a class with static members with | ||
| * cleaner, more concise syntax and semantics. |
There was a problem hiding this comment.
I would not duplicate this comment everywhere. It could be only in App.java.
| * @throws IOException if program is not able to find log files (output.txt and error.txt) | ||
| */ | ||
| @Test | ||
| public void positiveTestFileMessage() throws IOException { |
There was a problem hiding this comment.
I would reconsider JUnit test method naming. See the other patterns for examples.
|
@inbravo is this ready for another review? |
|
Your third comment on module/src/main/java/com/iluwatar/module/App.java, require clarification. Kindly advise. |
|
@inbravo yes, so instead of this You could write |
|
Code is Done! as per all review comments ..... |
|
Well done @inbravo 👍 Thank you for the new pattern! |
|
@all-contributors please add @inbravo for code |
|
I've put up a pull request to add @inbravo! 🎉 |
Pull request for Module pattern #62