Skip to content

chore: add test case for #409 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

chore: add test case for #409 #416

merged 1 commit into from
Mar 28, 2025

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Mar 28, 2025

No description provided.

Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 0816c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin JounQin requested a review from Copilot March 28, 2025 16:29
Copilot

This comment was marked as outdated.

Copy link

socket-security bot commented Mar 28, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected]7.27.0 None 0 0 B

View full report↗︎

@JounQin
Copy link
Collaborator Author

JounQin commented Mar 28, 2025

@ljharb I requested to install @coderabbitai GitHub App on this repository.

Copy link
Contributor

github-actions bot commented Mar 28, 2025

size-limit report 📦

Path Size
lib/index.js 1.35 KB (0%)

Copy link

pkg-pr-new bot commented Mar 28, 2025

Open in Stackblitz

npm i https://pkg.pr.new/import-js/eslint-import-resolver-typescript@416

commit: 0816c8c

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test case for issue #409 and includes related configuration updates.

  • Added a test file in tests/nestedPackageJson to cover the functionality of the combine export.
  • Updated ESLint configuration and JSDoc to support multiple project paths.
  • Revised sponsor tables in the README, updated Yarn version, and added an extra environment variable for release workflows.

Reviewed Changes

Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/nestedPackageJson/test.ts Added a file exporting the combine function for testing.
tests/nestedPackageJson/.eslintrc.cjs Introduced a custom ESLint configuration for nested tests.
tests/base.eslintrc.cjs Updated JSDoc type for the project parameter.
README.md Revised sponsor tables formatting.
.yarnrc.yml Upgraded yarn version from 4.7.0 to 4.8.0.
.github/workflows/release.yml Added NPM_CONFIG_PROVENANCE environment variable.
Files not reviewed (5)
  • .nvmrc: Language not supported
  • package.json: Language not supported
  • tests/nestedPackageJson/.gitignore: Language not supported
  • tests/nestedPackageJson/package.json: Language not supported
  • tests/nestedPackageJson/tsconfig.json: Language not supported
Comments suppressed due to low confidence (1)

tests/nestedPackageJson/test.ts:1

export { combine } from '@atlaskit/pragmatic-drag-and-drop/combine'

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin merged commit 35d67f2 into master Mar 28, 2025
44 of 45 checks passed
@JounQin JounQin deleted the chore/issue_409 branch March 28, 2025 16:47
@ljharb
Copy link
Member

ljharb commented Mar 28, 2025

@JounQin yep, saw that, was traveling yesterday. just approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants