-
-
Notifications
You must be signed in to change notification settings - Fork 69
chore: add test case for #409 #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
@ljharb I requested to install @coderabbitai GitHub App on this repository. |
size-limit report 📦
|
commit: |
64c638b
to
5f3d568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a test case for issue #409 and includes related configuration updates.
- Added a test file in tests/nestedPackageJson to cover the functionality of the combine export.
- Updated ESLint configuration and JSDoc to support multiple project paths.
- Revised sponsor tables in the README, updated Yarn version, and added an extra environment variable for release workflows.
Reviewed Changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/nestedPackageJson/test.ts | Added a file exporting the combine function for testing. |
tests/nestedPackageJson/.eslintrc.cjs | Introduced a custom ESLint configuration for nested tests. |
tests/base.eslintrc.cjs | Updated JSDoc type for the project parameter. |
README.md | Revised sponsor tables formatting. |
.yarnrc.yml | Upgraded yarn version from 4.7.0 to 4.8.0. |
.github/workflows/release.yml | Added NPM_CONFIG_PROVENANCE environment variable. |
Files not reviewed (5)
- .nvmrc: Language not supported
- package.json: Language not supported
- tests/nestedPackageJson/.gitignore: Language not supported
- tests/nestedPackageJson/package.json: Language not supported
- tests/nestedPackageJson/tsconfig.json: Language not supported
Comments suppressed due to low confidence (1)
tests/nestedPackageJson/test.ts:1
- The test file currently only re-exports the combine function; please add actual test cases or assertions to validate its behavior as intended for issue
import/no-unresolved
unable to resolve@atlaskit/pragmatic-drag-and-drop
’s nested imports after upgrading 3.8.7 → 4.2.4 #409.
export { combine } from '@atlaskit/pragmatic-drag-and-drop/combine'
5f3d568
to
0816c8c
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@JounQin yep, saw that, was traveling yesterday. just approved. |
No description provided.