fix: remove buggy module-sync exports field
#450
Conversation
🦋 Changeset detectedLatest commit: afecb4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update removes the "module-sync" and "default" export entries from the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2568d85 in 35 seconds. Click for details.
- Reviewed
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/FUNDING.yml:11
- Draft comment:
Updated the afdian URL from 'afdian.net/@JounQin' to 'afdian.com/a/JounQin'. Confirm this correction is intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm their intention regarding a URL change. This falls under the rule of not asking the author to confirm their intention or to ensure the behavior is intended. Therefore, this comment should be removed.
2. package.json:24
- Draft comment:
Removed the non-standard 'module-sync' and duplicate 'default' export fields. Ensure these removals won't impact legacy tooling. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to ensure that the removals won't impact legacy tooling, which is against the rules. It doesn't provide a specific suggestion or ask for a specific test to be written. Therefore, it should be removed.
Workflow ID: wflow_1OFK31Gg52uELnO1
You can customize 
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unintended export path (module-sync) along with a redundant default fallback in the package exports, and updates the Afdian sponsorship URL.
- Remove
module-syncexport entry - Remove extra
defaultexport fallback - Update Afdian link in FUNDING.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Dropped module-sync subpath and redundant default |
| .github/FUNDING.yml | Switched Afdian URL to the correct domain |
commit: |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 64.45% 64.45%
=======================================
Files 6 6
Lines 377 377
Branches 49 49
=======================================
Hits 243 243
Misses 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/rude-teachers-look.md (1)
5-5: Ensure changeset description matches all removals
The summary line references removal of themodule-syncexport field. If the patch also removes the"default"export entry, consider updating this description to document both removals for complete clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
.changeset/rude-teachers-look.md(1 hunks).github/FUNDING.yml(1 hunks)package.json(0 hunks)
💤 Files with no reviewable changes (1)
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
🔇 Additional comments (2)
.github/FUNDING.yml (1)
11-11: Update custom funding URL
The AfDian link has been updated tohttps://afdian.com/a/JounQin, which aligns with the new domain format. Please verify that this URL resolves correctly and matches the pattern used by other contributors..changeset/rude-teachers-look.md (1)
1-3: Verify frontmatter formatting
The YAML frontmatter is correctly structured, specifying apatchupdate foreslint-import-resolver-typescript.
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 4.3.4 | 4.3.5 | ## [v4.3.5](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#435) ##### Patch Changes - [#450](import-js/eslint-import-resolver-typescript#450) [`3f1aab1`](import-js/eslint-import-resolver-typescript@3f1aab1) Thanks [@JounQin](https://github.com/JounQin)! - fix: remove buggy `module-sync` exports field
nodejs/node#57869
Important
Remove buggy
module-syncexport field frompackage.jsonand update URL in.github/FUNDING.yml.module-syncexport field frompackage.jsonto fix a bug..github/FUNDING.ymlfromhttps://afdian.net/@JounQintohttps://afdian.com/a/JounQin.This description was created by
for 2568d85. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit