`newline-after-import` deosn't take care of comments

[neurolag]

The newline-after-import rule doesn't hit if the import-statements are immediately followed by comments:

This piece of code is expected to produce an error, but it doesn't:

import { join } from "path";
/**
 *
 */
console.log();

[ljharb]

From where do you form this expectation? The docs don't have any examples with comments, nor do the tests.

The goal of the rule is to ensure that there's some spacing between imports and non-imports - arguably a comment suffices.

[alvis]

I come to this issue for the exact same problem. In the OP's case, I'd expect

import { join } from "path";

/**
 *
 */
console.log();

The examples and tests may not include comment into consideration but I find it more intuitive and more clear if there's an empty line after all the import statements. After all, I believe it's the intention of the rule. For example, the following annoying example doesn't make sense to me but it's a pass today:

import something from 'somewhere';
// it's a very looooooooooooooooooooooooooooooooooooog comment
console.log('is it a good quality code?')

[ljharb]

A PR to add an option to make comments not be counted as an empty line would be appreciated.

[ftzi]

Coming for the same reason. Don't have knowledge with eslint plugins nor the time to get into it right now.

[pri1311]

Hey! I would like to work on this.

[ljharb]

Go for it!