You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #340, the extensions rule should ignore imports from packages with invalid names. E.g. files:../../content/**/*.md is not a file path, and not a valid package name.
I suppose this might have to deal with Windows file paths though.
The text was updated successfully, but these errors were encountered:
Sure. I maintain two Babel plugins which rewrite import statements: import-glob and files. An example of the latter is here:
importfilesfrom'files:../../content/**/*.md'
The import isn't a file path (no leading / or disk drive, no leading period), and neither is files:.. a valid package name. Since the extensions rule only deals with file extensions, and this isn't a valid import (because it uses a custom resolver), I don't think the rule should apply.
I suppose this might be solved by writing a resolver for these Babel plugins (though I haven't checked whether this rule follows resolvers). It might be useful for this rule not to result in errors even if there is no custom resolver.
novemberborn
added a commit
to novemberborn/eslint-plugin-as-i-preach
that referenced
this issue
May 16, 2016
Similar to #340, the extensions rule should ignore imports from packages with invalid names. E.g.
files:../../content/**/*.md
is not a file path, and not a valid package name.I suppose this might have to deal with Windows file paths though.
The text was updated successfully, but these errors were encountered: