Skip to content

exclude tests from coverage + bump TS parser #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2018
Merged

exclude tests from coverage + bump TS parser #1095

merged 4 commits into from
May 4, 2018

Conversation

benmosher
Copy link
Member

TIL the test files were included in the coverage stats. 🤦‍♂️

@coveralls
Copy link

coveralls commented May 3, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 97.184% when pulling 1e86050 on fix-coverage into f0d0c4f on master.

@ljharb
Copy link
Member

ljharb commented May 4, 2018

so is there now no more coverage script at all?

@benmosher
Copy link
Member Author

nah, those were old ones. the test script runs nyc every time. I think I just never cleaned up the pre-nyc istanbul scripts.

also: not sure what I did to screw up ESLint 2 and 3, now...

@benmosher
revert babel-eslint to 8.0.x
1e86050 
seems to have some weird co-interaction with older ESLint. 🤷🏼‍♂️
@benmosher benmosher merged commit cd9d249 into master May 4, 2018
@benmosher benmosher deleted the fix-coverage branch May 4, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmosher @coveralls @ljharb