Skip to content

[Rules] add meta.type for all rules #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

[Rules] add meta.type for all rules #1236

merged 1 commit into from
Dec 4, 2018

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Nov 18, 2018

This PR fixes #1229 .

It adds meta.type for the rules. meta.type is added since ESLint 5.9.0 and described here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.36% when pulling ef03f7c on ljqx:meta-type into 798eed7 on benmosher:master.

@coveralls
Copy link

coveralls commented Nov 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.36% when pulling 5101b73 on ljqx:meta-type into 798eed7 on benmosher:master.

ljharb
ljharb reviewed Nov 18, 2018
View reviewed changes
ljharb
ljharb approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let’s be sure this is rebased down to a single commit before merging.

@ljqx
Copy link
Contributor Author

ljqx commented Nov 18, 2018

@ljharb , thanks, rebased

@ljharb ljharb merged commit 1cd82eb into import-js:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the new rule meta.type property
3 participants
@ljqx @coveralls @ljharb