Skip to content

[Tests] import/order: add test cases for type imports order #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

7nik
Copy link

@7nik 7nik commented Dec 14, 2022

Theoretically, fixing this test case should close #2441

Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Nov 16, 2024
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Nov 16, 2024
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 23, 2024
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 23, 2024
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 23, 2024
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 30, 2024
@ljharb ljharb force-pushed the import/order-type-import-order branch from d667327 to f7500da Compare December 31, 2024 06:36
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 31, 2024
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 31, 2024
…`, `consolidateIslands`) to allow intragroup sorting of type-only imports

Closes import-js#2912
Closes import-js#2347
Closes import-js#2441
Subsumes import-js#2615
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Dec 31, 2024
…`, `consolidateIslands`) to allow intragroup sorting of type-only imports

Closes import-js#2912
Closes import-js#2347
Closes import-js#2441
Subsumes import-js#2615
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (fa36d49) to head (f7500da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
- Coverage   95.47%   92.06%   -3.42%     
==========================================
  Files          83       83              
  Lines        3628     3629       +1     
  Branches     1281     1282       +1     
==========================================
- Hits         3464     3341     -123     
- Misses        164      288     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Jan 21, 2025
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Jan 23, 2025
@ljharb ljharb closed this in #3104 Jan 23, 2025
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Jan 23, 2025
ljharb pushed a commit to ljharb/eslint-plugin-import that referenced this pull request Jan 23, 2025
Xunnamius added a commit to Xunnamius/eslint-plugin-import that referenced this pull request Jan 26, 2025
ljharb pushed a commit to Xunnamius/eslint-plugin-import that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

import/order: "type" group is not enough
2 participants