Skip to content

eslint-module-utils: filePath in parserOptions #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2017
Merged

eslint-module-utils: filePath in parserOptions #840

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4d75c8
eslint-module-utils: filePath in parserOptions
sompylasar May 19, 2017
3544c0f
eslint-module-utils: Add tests for parserOptions
sompylasar May 20, 2017
7712ce1
eslint-module-utils: Reverted manual version bumps.
sompylasar May 20, 2017
d4246fb
Merge branch 'benmosher/master' into patch-2
sompylasar May 26, 2017
d0007f2
Add sinon, replace eslint-module-utils test spy with sinon.spy
sompylasar May 26, 2017
7ac5e8f
Fix CHANGELOG merge error
sompylasar May 26, 2017
d397b9b
eslint-module-utils: Add more tests for parse (coverage 100%)
sompylasar May 26, 2017
5732742
eslint-module-utils: In tests move require stub parser to the top.
sompylasar May 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions utils/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ exports.default = function parse(path, content, context) {

// always attach comments
parserOptions.attachComment = true

// provide the `filePath` like eslint itself does, in `parserOptions`
// https://github.com/eslint/eslint/blob/3ec436eeed0b0271e2ed0d0cb22e4246eb15f137/lib/linter.js#L637
parserOptions.filePath = path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the path needs to be path.normalized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. What is the error case? The serialized parserOptions participates in some cache key, right? Where is it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal parser has a cache that is a hash of the parse settings and the module path. So I'm guessing the path must be relative.

An absolute path would work, or the cache key could drop the file path key.

I am not at a computer right now but I think the cache access is in utils/resolve.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not thinking -- relative would be fine as long as it's all against cwd. So maybe path.normalize would be fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers, I'll look into that and suggest a change and tests when I get to my computer (afk, too).


// require the parser relative to the main module (i.e., ESLint)
const parser = moduleRequire(parserPath)
Expand Down