Skip to content

feat: add exponential backoff strategy for retry #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 7, 2020

Proposed Changes

  1. default value for RetryInterval is 5_000
  2. added exponential backoff strategy for batch writes
    1. added MaxRetries - the number of max retries when write fails - 3
    2. added MaxRetryDelay - the maximum delay between each retry attempt in milliseconds - 180_000
    3. added ExponentialBase - the base for the exponential retry delay, the next delay is computed as RetryInterval * ExponentialBase^(attempts-1) + random(JitterInterval)
    4. retry also network strategy
  3. other http request doesn't have retry strategy

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review October 8, 2020 06:39
@bednar bednar requested review from rhajek and rolincova October 8, 2020 07:16
@bednar bednar merged commit 8cdf878 into master Oct 8, 2020
@bednar bednar deleted the feat/expontential-retry branch October 8, 2020 11:42
@bednar bednar added this to the 1.13.0 milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants