Skip to content

fix: validate configuration when is client configured via file #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2021
Merged

fix: validate configuration when is client configured via file #143

merged 3 commits into from
Jan 7, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 5, 2021 •
edited
Loading

Closes #142

Proposed Changes

Added validation that a configuration is present when is client configured via file.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review January 5, 2021 09:18
@bednar bednar requested a review from rhajek January 5, 2021 09:18
@bednar bednar merged commit 20437d2 into master Jan 7, 2021
@bednar bednar deleted the fix/load-from-config-validation branch January 7, 2021 07:37
@bednar bednar added this to the 1.15.0 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Public methods but can not be used
2 participants
@bednar @rhajek