Skip to content

feat: use InfluxDB OSS API definitions to generated APIs #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 16, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 10, 2021

Closes #198
Closes #190

Proposed Changes

  • Use InfluxDB OSS API definitions to generated APIs.
  • Deprecated CreateAuthorizationAsync(Authorization authorization)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

bednar added 30 commits June 10, 2021 10:21
@bednar bednar changed the title Feat/api from openapi repository feat: use InfluxDB OSS API definitions to generated APIs Jun 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #206 (e4b8334) into master (b88ebfe) will decrease coverage by 0.20%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   85.41%   85.21%   -0.21%     
==========================================
  Files          71       71              
  Lines        6207     6221      +14     
==========================================
- Hits         5302     5301       -1     
- Misses        905      920      +15     
Impacted Files Coverage Δ
Client/InfluxDBClient.cs 97.65% <ø> (ø)
Client/NotificationRulesApi.cs 91.45% <ø> (-0.62%) ⬇️
Client/OrganizationsApi.cs 98.58% <ø> (+0.03%) ⬆️
Client/TelegrafsApi.cs 83.33% <ø> (ø)
Client/AuthorizationsApi.cs 86.84% <40.00%> (-10.22%) ⬇️
Client/BucketsApi.cs 74.09% <46.66%> (-2.38%) ⬇️
Client/DeleteApi.cs 100.00% <100.00%> (ø)
Client/FindOptions.cs 79.16% <0.00%> (-4.17%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88ebfe...e4b8334. Read the comment docs.

@bednar bednar marked this pull request as ready for review June 10, 2021 13:33
@bednar bednar requested a review from rhajek June 10, 2021 13:33
@rhajek
Copy link
Contributor

rhajek commented Jun 11, 2021

There are braking changes in management API, so we should increase major version in next release.

@bednar
Copy link
Contributor Author

bednar commented Jun 11, 2021

The major version is updated to 2.0.0.

@bednar bednar requested a review from rhajek June 14, 2021 07:49
@bednar bednar merged commit c6b882f into master Jun 16, 2021
@bednar bednar deleted the feat/api-from-openapi-repository branch June 16, 2021 07:13
@bednar bednar added this to the 1.20.0 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to assign authorization to a user? client.GetUsersApi().FindUsersAsync() only returns 20 users
3 participants