-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add QueryAsync overload with Type parameter (#230) #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
huh, why did it fail on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
There is a few requirements that should be satisfy before we accept the PR:
@bednar : okay I changed the code according to your comments |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 85.20% 85.09% -0.11%
==========================================
Files 71 71
Lines 6237 6280 +43
==========================================
+ Hits 5314 5344 +30
- Misses 923 936 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍. We are almost done.
Please also update the major version in following files:
- ./Client/Linq/Client.Linq.csproj
- ./Client.Legacy/Client.Legacy.csproj
- ./Examples/Examples.csproj
and check last requirement:
@bednar : done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I will merge this PR into master after release 2.1.0
at Friday.
Closes #230
Proposed Changes
This commit will add an overload to
QueryAsync
to allow aType
as parameter for the POCO object.Checklist
dotnet test
completes successfully