Skip to content

feat: add QueryAsync overload with Type parameter (#230) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2021

Conversation

maxreb
Copy link
Contributor

@maxreb maxreb commented Aug 16, 2021

Closes #230

Proposed Changes

This commit will add an overload to QueryAsync to allow a Type as parameter for the POCO object.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@maxreb
Copy link
Contributor Author

maxreb commented Aug 16, 2021

huh, why did it fail on GetRunLogs? The last messages does not seem to end with "Completed(success)" but I dont have a clue what this should mean, whether what is the TaskApi for.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There is a few requirements that should be satisfy before we accept the PR:

@maxreb
Copy link
Contributor Author

maxreb commented Aug 17, 2021

@bednar : okay I changed the code according to your comments

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #232 (1aa9023) into master (ce30df6) will decrease coverage by 0.10%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   85.20%   85.09%   -0.11%     
==========================================
  Files          71       71              
  Lines        6237     6280      +43     
==========================================
+ Hits         5314     5344      +30     
- Misses        923      936      +13     
Impacted Files Coverage Δ
Client.Core/Flux/Internal/FluxResultMapper.cs 62.74% <33.33%> (-1.91%) ⬇️
Client/QueryApi.cs 23.35% <46.15%> (+2.69%) ⬆️
Client.Core/Internal/AbstractQueryClient.cs 75.84% <100.00%> (+1.35%) ⬆️
Client/Internal/DefaultDomainObjectMapper.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce30df6...1aa9023. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍. We are almost done.

Please also update the major version in following files:
- ./Client/Linq/Client.Linq.csproj
- ./Client.Legacy/Client.Legacy.csproj
- ./Examples/Examples.csproj

and check last requirement:

@maxreb
Copy link
Contributor Author

maxreb commented Aug 18, 2021

@bednar : done

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I will merge this PR into master after release 2.1.0 at Friday.

@bednar bednar added this to the 3.0.0 milestone Aug 19, 2021
@bednar bednar merged commit 842f3c8 into influxdata:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make QueryAsync accept a Type instead of generic
4 participants