Skip to content

fix: change type of PermissionResource.type to string to avoid exception for non-existing item #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 21, 2022

Proposed Changes

The PermissionResource.Type is not constant value and can evolve as the API of InfluxDB changing.

=>

Change type of PermissionResource.Type to string.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #290 (d594137) into master (187e942) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files          73       73           
  Lines        6322     6322           
=======================================
  Hits         5639     5639           
  Misses        683      683           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187e942...d594137. Read the comment docs.

@bednar bednar force-pushed the permission_resource_type_as_string branch from bf68101 to 14f10a3 Compare February 23, 2022 07:12
@bednar bednar merged commit f583b6a into master Feb 23, 2022
@bednar bednar deleted the permission_resource_type_as_string branch February 23, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants