Skip to content

fix: get version from X-Influxdb-Version header #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2022
Merged

fix: get version from X-Influxdb-Version header #297

merged 5 commits into from
Mar 15, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 14, 2022

Closes #296

Proposed Changes

Fixed getting version from X-Influxdb-Version header.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review March 14, 2022 13:19
@bednar bednar requested a review from michaelahojna March 14, 2022 13:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #297 (7e577dc) into master (3a4bcb0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   89.24%   89.26%   +0.01%     
==========================================
  Files          73       73              
  Lines        6332     6332              
==========================================
+ Hits         5651     5652       +1     
+ Misses        681      680       -1     
Impacted Files Coverage Δ
Client/InfluxDBClient.cs 96.46% <ø> (ø)
Client.Core/Internal/AbstractRestClient.cs 96.77% <100.00%> (ø)
Client/Internal/RetryAttempt.cs 100.00% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4bcb0...7e577dc. Read the comment docs.

@bednar bednar merged commit 32cb4c3 into master Mar 15, 2022
@bednar bednar deleted the fix_version branch March 15, 2022 10:45
@bednar bednar added this to the 4.0.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How to check if a connection can be established?
3 participants