Skip to content

fix: Authentication Cookies follow redirects #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 7, 2022

Closes #302

Proposed Changes

The CookieContainer doesn't set Cookies if there is a redirect to other domain, we have to use custom Authenticator.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 7, 2022 07:29
@bednar bednar requested a review from rhajek April 7, 2022 07:29
@codecov-commenter
Copy link

Codecov Report

Merging #305 (4e088dc) into master (4fc6a85) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   88.32%   88.34%   +0.02%     
==========================================
  Files          74       74              
  Lines        6431     6446      +15     
==========================================
+ Hits         5680     5695      +15     
  Misses        751      751              
Impacted Files Coverage Δ
Client/Internal/ApiClient.cs 89.90% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc6a85...4e088dc. Read the comment docs.

@bednar bednar merged commit fcb0498 into master Apr 13, 2022
@bednar bednar deleted the cookies_follow_redirect branch April 13, 2022 15:15
@bednar bednar added this to the 4.1.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants