feat: add FluxRecord.Row with response data stored in List #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bednar
requested changes
Sep 29, 2022
Codecov ReportBase: 87.52% // Head: 87.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.02%
==========================================
Files 76 76
Lines 6638 6650 +12
==========================================
+ Hits 5810 5822 +12
Misses 828 828
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bednar
requested changes
Sep 30, 2022
michaelahojna
changed the title
bednar
requested changes
Oct 4, 2022
bednar
force-pushed
the
FluxRecord.Rows
branch
from
4cc6aaf to
956f230
Compare
bednar
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Adding possibility of accessing response data in List FluxRecord.Row.
In case of using pivot on data, where field contains labels that occur by default in the annotated CSV (f.e. "result" or "table"), could be duplicated column names in response. In that case FluxRecord.Values (Dictionary), which can hold only unique keys, doesn't show complete data. This edge case is solved by using FluxRecord.Row (List).
Checklist
dotnet testcompletes successfully