Skip to content

fix: Added Async suffix into asynchronous methods #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

fix: Added Async suffix into asynchronous methods #40

merged 1 commit into from
Oct 2, 2019

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 2, 2019

Closes #38

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added the bug Something isn't working label Oct 2, 2019
@bednar bednar added this to the 1.1.0 milestone Oct 2, 2019
@bednar bednar self-assigned this Oct 2, 2019
@bednar bednar merged commit 660643c into master Oct 2, 2019
@bednar bednar deleted the fix-naming-convention branch October 2, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bednar bednar

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

async calls should be named as such
1 participant
@bednar