Skip to content

fix: always close pure OkHttp3 response #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix: always close pure OkHttp3 response #151

merged 2 commits into from
Sep 16, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 14, 2020

Closes #146

Proposed Changes

The pure OkHttp3 response (not Retrofit) should be always closed.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #151 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
- Coverage     90.46%   90.39%   -0.08%     
  Complexity      439      439              
============================================
  Files           137      137              
  Lines          5393     5393              
  Branches        204      206       +2     
============================================
- Hits           4879     4875       -4     
- Misses          439      441       +2     
- Partials         75       77       +2     
Impacted Files Coverage Δ Complexity Δ
...luxdb/client/internal/AuthenticateInterceptor.java 98.27% <100.00%> (ø) 0.00 <0.00> (ø)
.../influxdb/client/internal/AbstractWriteClient.java 89.57% <0.00%> (-1.90%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a678cc...9a29759. Read the comment docs.

@bednar bednar marked this pull request as ready for review September 14, 2020 10:54
@bednar bednar requested a review from rhajek September 14, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: A connection to http://localhost:8086/ was leaked. Did you forget to close a response body?
3 participants