Skip to content

feat: improved logging message for retries #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 12, 2020

Proposed Changes

The message looks like:

The retriable error occurred during writing of data. Reason: 'org 04014de4ed590000 has exceeded limited_write plan limit'. Retry in 5000ms.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek October 12, 2020 12:42
@bednar bednar marked this pull request as ready for review October 12, 2020 12:42
@bednar bednar added this to the 1.13.0 milestone Oct 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (aee00f8) to head (2cf76f5).
Report is 522 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     90.30%   90.30%           
  Complexity      439      439           
=========================================
  Files           138      138           
  Lines          5427     5427           
  Branches        215      213    -2     
=========================================
  Hits           4901     4901           
  Misses          450      450           
  Partials         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar requested a review from rhajek October 15, 2020 09:35
@rhajek rhajek merged commit 7ad790d into master Oct 15, 2020
@bednar bednar deleted the feat/retries-logging branch October 15, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants