Skip to content

fix: Blocking API batches Point by precision #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 12, 2020

Closes #174

Proposed Changes

Fixed unnecessary API call when writing collection of Points.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #176 (f50ec6f) into master (2c8bf87) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     89.44%   89.39%   -0.06%     
  Complexity      440      440              
============================================
  Files           138      138              
  Lines          5427     5429       +2     
  Branches        214      214              
============================================
- Hits           4854     4853       -1     
- Misses          497      499       +2     
- Partials         76       77       +1     
Impacted Files Coverage Δ Complexity Δ
...influxdb/client/internal/WriteApiBlockingImpl.java 94.87% <100.00%> (-3.82%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8bf87...f50ec6f. Read the comment docs.

@bednar bednar marked this pull request as ready for review November 12, 2020 09:55
@bednar bednar requested a review from rhajek November 12, 2020 09:55
@bednar bednar merged commit e76f23f into master Nov 13, 2020
@bednar bednar deleted the fix/points-batches branch November 13, 2020 09:04
@bednar bednar added this to the 1.14.0 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to do batch write with block api?
3 participants