Skip to content

feat: Apache Karaf support #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2021
Merged

feat: Apache Karaf support #221

merged 4 commits into from
Apr 15, 2021

Conversation

borcsokj
Copy link
Contributor

@borcsokj borcsokj commented Apr 12, 2021

Closes #219

Proposed Changes

Apache Karaf support (depends on #220 )

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@borcsokj borcsokj changed the title Feat/karaf support feat:karaf support Apr 12, 2021
@borcsokj borcsokj changed the title feat:karaf support feat: Apache Karaf support Apr 12, 2021
@bednar
Copy link
Contributor

bednar commented Apr 13, 2021

Thanks again for your PR 👍 , let's first finish #220...

@bednar
Copy link
Contributor

bednar commented Apr 14, 2021

@borcsokj, please rebase sources to resolve conflicts with merged #220

@bednar bednar self-requested a review April 14, 2021 05:46
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your awesome PR 👍... There is a few requirements that should be satisfy before we accept the PR:

  1. Apply following git patch that will add karaf module into CircleCI caching strategy:

and a few following requirements in code:

@borcsokj borcsokj requested a review from bednar April 14, 2021 09:58
@borcsokj
Copy link
Contributor Author

@bednar, thanks for your review, I applied changes you wrote.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍... We are ready to merge

@bednar bednar merged commit 13ab60b into influxdata:master Apr 15, 2021
@bednar bednar added this to the 2.2.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSGi support
2 participants