-
Notifications
You must be signed in to change notification settings - Fork 130
feat: Apache Karaf support #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks again for your PR 👍 , let's first finish #220... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your awesome PR 👍... There is a few requirements that should be satisfy before we accept the PR:
- Apply following git patch that will add
karaf
module into CircleCI caching strategy:- circleci_patch.txt
git apply circleci_patch.txt
and a few following requirements in code:
@bednar, thanks for your review, I applied changes you wrote. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍... We are ready to merge
Closes #219
Proposed Changes
Apache Karaf support (depends on #220 )
Checklist
mvn test
completes successfully