Skip to content

fix: avoid requirements to jdk.unsupported module #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 25, 2021

Closes #256

Proposed Changes

  1. Avoid requirements to jdk.unsupported module. workaround: --add-modules jdk.unsupported
  2. Update GSON to 2.8.8:
    image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #258 (f975a0c) into master (050db6a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     89.17%   89.17%           
  Complexity      449      449           
=========================================
  Files           145      145           
  Lines          5773     5773           
  Branches        272      272           
=========================================
  Hits           5148     5148           
  Misses          545      545           
  Partials         80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050db6a...f975a0c. Read the comment docs.

@bednar bednar changed the title fix: avoid requirements to java.sql and jdk.unsupported module fix: avoid requirements to jdk.unsupported module Aug 26, 2021
@bednar bednar merged commit 829f1ce into master Aug 31, 2021
@bednar bednar deleted the fix/java-modules branch August 31, 2021 09:11
@bednar bednar added this to the 3.3.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException: Unable to create @Body converter for class Query
3 participants