Skip to content

fix: serialization null tag's value into LineProtocol #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 30, 2021

Closes #282

Proposed Changes

Fixed serialization a Point into LineProtocol when tag's value is null.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #283 (05e18b2) into master (f2ef610) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #283   +/-   ##
=========================================
  Coverage     89.71%   89.71%           
  Complexity      473      473           
=========================================
  Files           149      149           
  Lines          5912     5912           
  Branches        283      283           
=========================================
  Hits           5304     5304           
  Misses          524      524           
  Partials         84       84           
Impacted Files Coverage Δ
...src/main/java/com/influxdb/client/write/Point.java 90.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ef610...05e18b2. Read the comment docs.

@bednar bednar marked this pull request as ready for review November 30, 2021 07:34
@bednar bednar requested a review from rhajek November 30, 2021 07:42
@bednar bednar merged commit 17fb8fa into master Nov 30, 2021
@bednar bednar deleted the fix/tag-null branch November 30, 2021 13:07
@bednar bednar added this to the 4.1.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client failing to save when Tag value is null
3 participants