-
Notifications
You must be signed in to change notification settings - Fork 130
fix: publishing runtime error as a WriteErrorEvent #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=========================================
Coverage 88.92% 88.92%
Complexity 473 473
=========================================
Files 149 149
Lines 5988 5988
Branches 290 290
=========================================
Hits 5325 5325
Misses 580 580
Partials 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍. There are a few requirements that must be be satisfy before we accept the PR:
- Please rebase your sources with master to fix conflicts in
CHANGELOG.md
. - Please update license header in
PublishRuntimeErrorAsWriteErrorEvent.java
by:mvn license:format
Regards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost done. There's one last code style requirement:
* https://github.com/influxdata/influxdb-client-java/issues/291 | ||
*/ | ||
@RunWith(JUnitPlatform.class) | ||
public class PublishRuntimeErrorAsWriteErrorEvent extends AbstractInfluxDBClientTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename class and file to PublishRuntimeErrorAsWriteErrorEventTest
.
public class PublishRuntimeErrorAsWriteErrorEvent extends AbstractInfluxDBClientTest { | |
public class PublishRuntimeErrorAsWriteErrorEventTest extends AbstractInfluxDBClientTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I pushed this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed I forgot to save the refactor after the file rename and you had to rename the class yourself, thank you!
Closes #291
Proposed Changes
Publishing runtime error as a WriteErrorEvent
Checklist
mvn test
completes successfully