Skip to content

chore: explicit exclusion old one gson dependency #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 22, 2022

Related to #342
Related to #338

Proposed Changes

This PR explicitly exclude dependencies to gson:2.8.x.

The Maven is not deterministic in resolving transient dependency. Maven chooses the first library it finds and it can be the older version (for more info see https://www.baeldung.com/maven-version-collision).

Dependency report

Before

...
[INFO] |  +- io.gsonfire:gson-fire:jar:1.8.5:compile
[INFO] |  |  \- (com.google.code.gson:gson:jar:2.8.6:compile - omitted for conflict with 2.9.0)
[INFO] |  +- com.squareup.retrofit2:converter-scalars:jar:2.9.0:compile
[INFO] |  |  \- (com.squareup.retrofit2:retrofit:jar:2.9.0:compile - omitted for duplicate)
[INFO] |  +- com.squareup.retrofit2:converter-gson:jar:2.9.0:compile
[INFO] |  |  +- (com.squareup.retrofit2:retrofit:jar:2.9.0:compile - omitted for duplicate)
[INFO] |  |  \- (com.google.code.gson:gson:jar:2.8.5:compile - omitted for conflict with 2.9.0)
[INFO] |  \- com.google.code.findbugs:jsr305:jar:3.0.2:compile
...

After

[INFO] |  +- io.gsonfire:gson-fire:jar:1.8.5:compile
[INFO] |  +- com.squareup.retrofit2:converter-scalars:jar:2.9.0:compile
[INFO] |  |  \- (com.squareup.retrofit2:retrofit:jar:2.9.0:compile - omitted for duplicate)
[INFO] |  +- com.squareup.retrofit2:converter-gson:jar:2.9.0:compile
[INFO] |  |  \- (com.squareup.retrofit2:retrofit:jar:2.9.0:compile - omitted for duplicate)
[INFO] |  \- com.google.code.findbugs:jsr305:jar:3.0.2:compile

Checklist

  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 22, 2022 07:27
@bednar bednar requested a review from rhajek April 22, 2022 07:28
@bednar bednar merged commit b4b918d into master Apr 28, 2022
@bednar bednar deleted the explicit_exclusion_of_gson branch April 28, 2022 08:02
@bednar bednar added this to the 6.1.0 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants