Skip to content

feat: add HTTP status code to detail message of InfluxException, add GatewayTimeoutException for 504 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 23, 2022

Proposed Changes

  1. Added HTTP status code to detail message of the InfluxException => logged exception looks like: HTTP status code: 501; Message: Wrong query"
  2. Added GatewayTimeoutException for HTTP status code 504

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar force-pushed the exception-status-code branch from acbb1dc to b1fb3a2 Compare June 23, 2022 13:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #367 (5ad3e97) into master (65d0398) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage     88.99%   89.00%           
  Complexity      635      635           
=========================================
  Files           155      156    +1     
  Lines          6344     6348    +4     
  Branches        303      303           
=========================================
+ Hits           5646     5650    +4     
  Misses          612      612           
  Partials         86       86           
Impacted Files Coverage Δ
...m/influxdb/client/internal/InfluxDBClientImpl.java 89.47% <ø> (ø)
...m/influxdb/exceptions/GatewayTimeoutException.java 100.00% <100.00%> (ø)
.../java/com/influxdb/exceptions/InfluxException.java 96.49% <100.00%> (+0.06%) ⬆️
...java/com/influxdb/internal/AbstractRestClient.java 73.77% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d0398...5ad3e97. Read the comment docs.

@bednar bednar marked this pull request as ready for review June 23, 2022 14:15
@bednar bednar requested a review from rhajek June 23, 2022 14:15
@bednar bednar force-pushed the exception-status-code branch from e19a847 to 5ad3e97 Compare June 24, 2022 08:00
@bednar bednar added this to the 6.3.0 milestone Jun 24, 2022
@bednar bednar merged commit 6bdad46 into master Jun 24, 2022
@bednar bednar deleted the exception-status-code branch June 24, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants