Skip to content

feat: interceptor warning already signed out #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 24, 2025

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 18, 2025

Closes Issue

Proposed Changes

_ Prevent duplicate interceptors in the OkHttpBuilder

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 18, 2025
@NguyenHoangSon96 NguyenHoangSon96 linked an issue Feb 18, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (4c87d07) to head (7fe8bdc).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #821   +/-   ##
=========================================
  Coverage     88.50%   88.51%           
  Complexity      787      787           
=========================================
  Files           174      174           
  Lines          7203     7207    +4     
  Branches        405      405           
=========================================
+ Hits           6375     6379    +4     
  Misses          697      697           
  Partials        131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 requested review from bednar and karel-rehor and removed request for bednar February 24, 2025 08:23
Copy link

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Makes sense.

@NguyenHoangSon96 NguyenHoangSon96 merged commit 7fe8bdc into master Mar 24, 2025
12 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/warning-already-signed-out branch March 24, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irritating warning Already signed out
4 participants