Skip to content

fix: HTTP request return type for Management API [async/await] #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2022
Merged

fix: HTTP request return type for Management API [async/await] #531

merged 3 commits into from
Nov 10, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 8, 2022 •
edited
Loading

Proposed Changes

This PR fixes the return type for *_async(...) methods in management API. The async management API returns required object not tuple with HTTP status and headers.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from powersj November 8, 2022 20:51
@bednar bednar marked this pull request as ready for review November 8, 2022 20:51
@bednar bednar mentioned this pull request Nov 8, 2022
Merged
3 tasks
powersj
powersj approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bednar bednar merged commit d515488 into master Nov 10, 2022
@bednar bednar deleted the fix_management_async_apis branch November 10, 2022 07:28
@bednar bednar added this to the 1.35.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bednar @powersj