fix: serialize Pandas NaN values into LineProtocol #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karel-rehor
reviewed
Apr 15, 2024
| @@ -20,7 +20,8 @@ def _itertuples(data_frame): | |||
|
|
|||
|
|
|||
| def _not_nan(x): | |||
| return x == x | |||
| from ...extras import pd | |||
There was a problem hiding this comment.
I see this same import occurs on line 91. Wouldn't it be more efficient to import this once at the head of the file?
There was a problem hiding this comment.
@karel-rehor, nice catch! Thank you 👍. I've uploaded the fixed version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.02%
==========================================
Files 39 39
Lines 3509 3505 -4
==========================================
- Hits 3173 3169 -4
Misses 336 336 ☔ View full report in Codecov by Sentry. |
karel-rehor
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590
Proposed Changes
Fixed serialisation Pandas NaN values into LineProtocol.
Checklist
pytest testscompletes successfully