-
Notifications
You must be signed in to change notification settings - Fork 14
PTEUDO-2363: Implement AWS provider #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bfabricio
wants to merge
26
commits into
main
Choose a base branch
from
PTEUDO-2363
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr:
While this may seem like a medium refactor, the core change is simply moving
awsprovider.go
behind the new provider interface, with some improvements in the code flow.Design decisions:
Testing:
This refactor significantly improves test coverage. Since the provider logic is now decoupled from the reconciler, we can move from almost 0% unit test coverage to full testability of interactions with Crossplane or other providers. Also, we can mock the provider in DatabaseClaimReconciler tests to precisely validate what is being passed.
Along with increased unit test coverage we must ensure the crossplane aws resource creation/update behavior remains unchanged, that can be done trough regression.
Missing: