refactor: modify style of Zenith functions #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anna-carroll
commented
May 29, 2024
anna-carroll
commented
- refactor from structs as params & big loops -> single-token-per-function call.
- this means that callers need to submit multiple function calls in a batch transaction, rather than a single function call which performs a batch of transfers.
- refactor from two function signatures per token function -> single function signature with if/else
- from "submit" and "submitEth" -> single "submit" with an if/else
anna-carroll
commented
May 29, 2024
| @@ -12,53 +12,25 @@ contract Passage { | |||
| /// @notice The address that is allowed to withdraw funds from the contract. | |||
| address public immutable withdrawalAdmin; | |||
|
|
|||
| /// @notice Thrown when attempting to fulfill an exit order with a deadline that has passed. | |||
| error OrderExpired(); | |||
There was a problem hiding this comment.
this was no longer used in the Host passage contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.