This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Bump deps and update to changes in them #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
changed the title
cardano-sl changes
deepfire
force-pushed
the
serge/bump-deps
branch
from
1bee760 to
3f9894c
Compare
deepfire
force-pushed
the
serge/bump-deps
branch
3 times, most recently
from
ef8ae5c to
3f35ebe
Compare
deepfire
force-pushed
the
serge/bump-deps
branch
2 times, most recently
from
fc9f41f to
d04a120
Compare
deepfire
changed the title
cardano-sl changes
mrBliss
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Looks good to me.
I would prefer to rebase this PR so that we don't have a commit introducing the extra dependencies and then another removing them again 🙂. I don't think this adds much to the Git history of cardano-byron-proxy.
BTW, do we need all the dependency pins? For example, all these test subdirs, do we really need them for this repository? I removed some of them in ouroboros-network by trial & error.
Comment on lines
98
to
102
| source-repository-package | ||
| type: git | ||
| location: https://github.com/input-output-hk/ouroboros-network | ||
| tag: d3e71facd53da4a2c72e4947f551ddeac45fba41 | ||
| tag: 2441f25ee5a2da0fbf008f3e9a1b1fd4e57f1de3 | ||
| subdir: ouroboros-network-testing |
There was a problem hiding this comment.
Unrelated to this PR: do we actually need ouroboros-network-testing? It only exports Ouroboros.Network.Testing.QuickCheck and Ouroboros.Network.Testing.Serialsie.
deepfire
force-pushed
the
serge/bump-deps
branch
from
991f7e6 to
9650e34
Compare
|
@mrBliss, did the cleanup. |
disassembler
approved these changes
Oct 30, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 30, 2019
59: Bump deps and update to changes in them r=deepfire a=deepfire This: 1. Bumps dependencies to the version used in `cardano-node`, 2. Uses a bumped `cardano-sl` with input-output-hk/cardano-sl#4247 3. Updates to changes in `cardano-ledger` and `ouroboros-network` 4. Adds new dependencies to facilitate the above. Co-authored-by: Kosyrev Serge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
cardano-node,cardano-slwith Single-machine multi-node mixed cluster CI prerequisites cardano-sl#4247cardano-ledgerandouroboros-network